Skip to content

Conversation

@brianfajardo
Copy link

Hi friends,

I noticed when I was going through the docs, if you're on /docs/example-reach-router and you clicked the next button, you'd be lead to the 404 page. But clicking on External Examples in the sidebar brought you to the next page following the Reach Router example.

I took a look at the code and it looks like example-reach-transition-group is not a thing anymore. So I figured example-reach-transition-group might just be a dangling piece of code in sidebars.json and removed it.

Seems to do the trick. In the Reach Router doc the next button now takes the user to the expected External Examples.

Button before:

Screen Shot 2019-03-22 at 10 59 01 AM

Button after change:

Screen Shot 2019-03-22 at 10 58 26 AM

@alexkrolick
Copy link
Collaborator

I think that should say "react-transition-group"

@brianfajardo
Copy link
Author

oh, awkward hahaha, that works too :^)

@alexkrolick alexkrolick merged commit c6546b9 into testing-library:master Mar 23, 2019
@alexkrolick
Copy link
Collaborator

Thanks for the heads up that something was amiss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants