Skip to content

Conversation

PaulACoroneos
Copy link

Remove dead cypress testing library example link (file no longer exists)

Copy link
Member

@m98 m98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verify that the fine does not exist and should be removed, or replaced with an alternative.
For now, it seems the change is necessary.

@m98
Copy link
Member

m98 commented Sep 9, 2020

@kentcdodds This is good to be merged

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 8f79416 into testing-library:master Sep 9, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @PaulACoroneos for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @PaulACoroneos! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @m98 for review

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @m98! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @eps1lon for docs and review

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @eps1lon! 🎉

@kentcdodds
Copy link
Member

Sorry I forgot to add you forever ago @eps1lon 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants