Skip to content

docs: fix cheatsheet example #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

docs: fix cheatsheet example #587

merged 2 commits into from
Oct 1, 2020

Conversation

prxg22
Copy link
Contributor

@prxg22 prxg22 commented Aug 29, 2020

this PR makes render's example in https://testing-library.com/docs/react-testing-library/cheatsheet correct by using findAllByText to wait for multiple elements.
@prxg22 prxg22 force-pushed the docs/fix-react-cheatsheet-example branch from e3ab3b4 to 08b50dc Compare August 29, 2020 15:11
eps1lon
eps1lon approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
eps1lon
eps1lon requested changes Aug 29, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot: We also need to update the destructured method on line 20
@nickserv
Copy link
Member

Maybe we should also remove the explanation of what's returned by render (generally not needed with screen and the API docs detail this anyway) and use userEvent.click
@alexkrolick alexkrolick merged commit b883b44 into testing-library:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@prxg22 @nickserv @eps1lon @alexkrolick