Skip to content

Conversation

@timdeschryver
Copy link
Member

This PR makes the docs for user-event and jest-dom library agnostic because these can be used within multiple Testing Libraries.

Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good idea, but should we also make the user-event example use DOM Testing Library so it's more framework-neutral?

@timdeschryver
Copy link
Member Author

I was thinking the same thing, but I think most of the examples are written for React, so I left it as is.
It doesn't bother me that the examples are written for React because that's the most popular.
Because our API's are aligned, there isn't a big difference anyway.

@nickserv
Copy link
Member

nickserv commented Aug 26, 2020

True, but I'm more concerned about learning curve. While more users are probably familiar with React Testing Library over DOM Testing Library, I think DOM Testing Library examples would still be easier for users that aren't familiar with React yet. And given that the majority of testing library users are using the DOM or some DOM based framework, I think it's safe to assume that more users would have basic DOM knowledge than basic React knowledge (but without DOM, such as a native use case).

@timdeschryver
Copy link
Member Author

👍
I will update the examples accordingly, thanks for the input.

@timdeschryver timdeschryver force-pushed the docs/library-agnostic branch from 9be00e6 to c735c3d Compare August 31, 2020 18:16
@timdeschryver
Copy link
Member Author

The examples are updated.

@nickserv nickserv merged commit 9bf40c1 into master Aug 31, 2020
@nickserv nickserv deleted the docs/library-agnostic branch August 31, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants