Skip to content

Conversation

@JoelMarcey
Copy link
Contributor

screenshot 2019-02-26 19 00 48

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAS! Though I think it'd be cool to put this one near the top personally.

@JoelMarcey
Copy link
Contributor Author

JoelMarcey commented Feb 27, 2019

I was not going to be that presumptuous 😄

@kentcdodds
Copy link
Member

I'd there a reason the logo is Facebook open source and not just Facebook itself? I'm pretty sure product teams are using it at Facebook.

@JoelMarcey
Copy link
Contributor Author

I debated this actually, and I made this as a conscious decision. Because I help run our open source program at Facebook, and believe the program helped enable projects like React to use your great project, I went that route. Nothing nefarious - just wanted to tout our open source program.

Is that a big sticking point for you?

Sent with GitHawk

@kentcdodds
Copy link
Member

Not a big sticking point, but I would prefer the more readily recognizable and arguably more official looking facebook logo if you're amiable :)

@JoelMarcey
Copy link
Contributor Author

Ok. I will look into doing that. One thing I might ask - why not both? 😄 Maybe merge this and then I will see about sending a PR with the Facebook logo too?

@kentcdodds
Copy link
Member

Sounds good to me! What do you think Alex?

@alexkrolick
Copy link
Collaborator

I was going to suggest both, too 😉

@alexkrolick alexkrolick merged commit caf268f into testing-library:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants