Updates clientScript instructions to use module

[theinterned]

Module is preferable to absolute file path as it doesn't assume the location of node_modules folder and works better with monorepos using yarn workspaces etc. where dependencies may be hoiseted.

This { "module": "npm module" } syntax is documented here https://devexpress.github.io/testcafe/documentation/using-testcafe/configuration-file.html#clientscripts — see the example of how "loadsh" is loaded.

[benmonro]

@alexkrolick @theinterned is there docs on this syntax somewhere? I'm not familiar w/ it. also if this works, that doesn't look like valid json to me... is something off?

[theinterned]

oh right you are ... I edited this in the GitHub interface ... let me update

[theinterned]

@benmonro thanks for reviewing this. I updated the description with a link to the TestCafe docs for this syntax. https://devexpress.github.io/testcafe/documentation/using-testcafe/configuration-file.html#clientscripts

[benmonro]

oh very cool, I didn't realize they added that! Actually let me hold off on merging this, I want to see if we can simplify it even further and just do

{module:"@testing-library/dom"}

[theinterned]

I just tried running my repo with {module:"@testing-library/dom"} and it didn't work.

1) - Error in fixture.beforeEach hook - An error occurred in the '@testing-library/dom' module injected into the tested page. Make sure that this module can be executed in the browser environment. Error details: ReferenceError: require is not defined Browser: Chrome 80.0.3987.149 / macOS 10.15.4 

[benmonro]

dang. ok in that case i'll approve. :)

[theinterned]

This issue seems to be that the "main" entry in @testing-library/dom points to "dist/index.js", as opposed to the umd build — there is a "umd:main" entry in the package.json too, but I would guess TestCafe doesn't see that.

https://github.com/testing-library/dom-testing-library/blob/master/package.json#L5-L7

I hacked the main in my node modules folder:

- "main": "dist/index.js", + "main": "dist/@testing-library/dom.umd.js",

And the tests run with

{ "clientScripts": [ { "module": "@testing-library/dom" } ] }

[benmonro]

yeah @theinterned i filed an issue about this w/ testcafe way back: DevExpress/testcafe#4176

looks like it's still open