Update example-react-router.md #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The first example test did not pass because we expected the element to be a heading not a div. Next the assertion for a no match route is 404 Not Found
alexkrolick approved these changes Dec 2, 2019
| Something is up with the Docusaurus build - might be something we could fix by checking in the lockfile |
afontcu approved these changes Dec 2, 2019
| Let's just merge it and hope it works 🤞 If not then we can look into fixing things. |
| @all-contributors please add @arturoromeroslc for docs |
| I've put up a pull request to add @arturoromeroslc! 🎉 |
| Whoops, made that too soon. |
| @all-contributors please add @arturoromeroslc for docs |
| I've put up a pull request to add @arturoromeroslc! 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The first example test did not pass because we expected the element to be a heading not a div.
Next the assertion for a no match route is 404 Not Found