updated example code per issue #202
Conversation
| | ||
| // snapshots work great with regular DOM nodes! | ||
| expect(container.firstChild).toMatchSnapshot() | ||
| expect(container).toMatchSnapshot() |
There was a problem hiding this comment.
Actually, while we're at it, maybe we should also swap .toMatchSnapshot with .toMatchInlineSnapshot. This will help to encourage people to keep snapshots smaller. This will require that we figure out what the snapshot will really look like so we can inline it. You up for that @Agentkma? If you need help let us know.
There was a problem hiding this comment.
Yes, I'm up for it. I will look into and let you know if I need help. I've just started learning and using this library, so this is a great opportunity to learn while helping improve things. Win-Win in my book :)
There was a problem hiding this comment.
Ok, so would we want to show a code snippet/or full component of the component(like the Svelt Testing example does?) to show how we find what the string arg to .toMatchInlineSnapshot() ?
There was a problem hiding this comment.
Yeah, that sounds good. It'll probably need to be something like:
expect(container).toMatchInlineSnapshot(` <div> <h1> Hello {name} ! </h1> </div> `)I'm not 100% certain that's how it will be serialized, but I'm pretty sure that's what it would look like.
| Is this in line with what you are looking for @kentcdodds ? Thanks |
| @all-contributors please add @Agentkma for docs |
| I've put up a pull request to add @Agentkma! 🎉 |
| Is this how this page is supposed to look? It looks like it interpreted the HTML in the snapshot. |
| Whoops! |
3 participants
Please Review
Searched for the ' expect(container.firstChild).toMatchSnapshot() ' in the docs and found 2 examples. Replaced both with ' expect(container).toMatchSnapshot() '