Skip to content

fix(a11y): underline links in a text block as pur WCAG 2.0 #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2024
Merged

fix(a11y): underline links in a text block as pur WCAG 2.0 #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a19180b
fix(a11y): underline links surrounded by text
Nov 11, 2024
2637f22
chore(name): updating class name to be clearer
Nov 11, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
}

[data-theme='dark']:root {
--ifm-color-primary: #7FA8F1;
--ifm-link-color: #7FA8F1;
--ifm-color-primary: #7fa8f1;
--ifm-link-color: #7fa8f1;
--docsearch-muted-color: white;
}

[data-theme='light']:root {
--ifm-color-primary: #1554B7;
--ifm-link-color: #1554B7;
--docsearch-muted-color: #494B5F;
--ifm-color-primary: #1554b7;
--ifm-link-color: #1554b7;
--docsearch-muted-color: #494b5f;
}

.wrapper {
Expand Down Expand Up @@ -483,6 +483,10 @@ details.alert div {
padding-top: 0;
}

.textBlockWithLinks a {
text-decoration: underline;
}

@media only screen and (min-width: 1024px) {
.projectTitle {
margin-top: 80px;
Expand Down
6 changes: 4 additions & 2 deletions src/pages/help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,20 @@ export default function Help(props) {
<h1 className="help-heading-1">Need help?</h1>
</header>
<GridBlock
className="textBlockWithLinks"
contents={supportLinks.slice(0, 3)}
layout="threeColumn"
align="left"
/>
<GridBlock
className="textBlockWithLinks"
contents={supportLinks.slice(3)}
layout="threeColumn"
align="left"
/>
<section>
<h2 className="help-heading-2">Buy a course</h2>
<p>
<p className="textBlockWithLinks">
Learn how to test JavaScript with{' '}
<ExternalLink href="https://kentcdodds.com">
Kent C. Dodds
Expand Down Expand Up @@ -105,7 +107,7 @@ export default function Help(props) {
community successful and improve tests for everyone in the long
run.
</p>
<p>
<p className="textBlockWithLinks">
Please consider helping us answer community questions and update
documentation content via the help links above. You can also help
support{' '}
Expand Down