chore: update deps #1157
chore: update deps #1157
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
package.json Outdated
| "docusaurus": "docusaurus" | ||
| "docusaurus": "docusaurus", | ||
| "pre-commit": "lint-staged", | ||
| "prepare": "git config core.hookspath .githooks" |
There was a problem hiding this comment.
This is usually not required for git hooks. The problem here is that now I wouldn't know how to disable git hooks on a per repo basis. I usually change the hooks path to something I own and then symlink the hooks that I do find usefull.
pre-commit hooks are something I will definitelly disable. So if you want to keep this as a pre-commit hook and not something else (e.g. pre-push), please add docs on how to disable this hook for this particular repository.
There was a problem hiding this comment.
👍 That's fair - AFAIK this can't support your use case.
Updating husky also isn't an option then because they also register the hookspath this way (from the docs: "Powered by modern new Git feature (core.hooksPath)").
I reverted the husky update to keep everything like it was as I currently don't see an easy way to disable certain hooks.
There was a problem hiding this comment.
@eps1lon could you give this another review please?
3 participants
Update docusaurus
Also updated lint-staged (the result of running
npm audit fix)Replaced husky with a simple githook, because the
pre-commitdidn't execute