Update setup.mdx #1058
Merged
Update setup.mdx #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added instruction on jsdom setup as it now isn't shipped with jest as of v28. https://jestjs.io/docs/upgrading-to-jest28#jsdom "If you are using JSDOM test environment, jest-environment-jsdom package now must be installed separately"
There was a problem hiding this comment.
Hi, thanks for creating this PR.
Do you also want to update the react setup docs?
timdeschryver approved these changes May 10, 2022
Done. #1061 |
| @all-contributors please add @abelhbeyene for docs |
| I've put up a pull request to add @abelhbeyene! 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added instruction on jsdom setup as it now isn't shipped with jest as of v28.
https://jestjs.io/docs/upgrading-to-jest28#jsdom
"If you are using JSDOM test environment, jest-environment-jsdom package now must be installed separately"