Skip to content

fix(vite): set ssr.noExternal even if not in project package.json #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2024
Merged

fix(vite): set ssr.noExternal even if not in project package.json #404

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd05580
fix(vite): set `ssr.noExternal` even if not present in project packag…
mcous Oct 11, 2024
1be6f67
fixup: deepClone from vitest
mcous Oct 11, 2024
f435ff5
fixup: silliness
mcous Oct 11, 2024
9126fcd
fixup: skip cleanup in globals mode
mcous Oct 18, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: silliness
  • Loading branch information
@mcous
mcous committed Oct 11, 2024
commit f435ff5c8f7a4df3a2e98b259acc3000bb3e5b51
80 changes: 40 additions & 40 deletions src/__tests__/vite-plugin.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { beforeEach, deepClone, describe, expect, test, vi } from 'vitest'
import { beforeEach, describe, expect, test, vi } from 'vitest'

import { svelteTesting } from '../vite.js'
import { IS_JEST } from './utils.js'
Expand All @@ -15,41 +15,41 @@ describe.skipIf(IS_JEST)('vite plugin', () => {
noExternal: false,
})

const config = {}
subject.config(config)
const result = {}
subject.config(result)

expect(config).toEqual({})
expect(result).toEqual({})
})

test('does not modify config if not Vitest', () => {
vi.stubEnv('VITEST', '')

const subject = svelteTesting()
const config = {}

subject.config(config)
const result = {}
subject.config(result)

expect(config).toEqual({})
expect(result).toEqual({})
})

test.each([
{
config: { resolve: { conditions: ['node'] } },
config: () => ({ resolve: { conditions: ['node'] } }),
expectedConditions: ['browser', 'node'],
},
{
config: { resolve: { conditions: ['svelte', 'node'] } },
config: () => ({ resolve: { conditions: ['svelte', 'node'] } }),
expectedConditions: ['svelte', 'browser', 'node'],
},
])(
'adds browser condition if necessary',
({ config, expectedConditions }) => {
const subject = svelteTesting()
const viteConfig = deepClone(config)

subject.config(viteConfig)
const result = config()
subject.config(result)

expect(viteConfig).toMatchObject({
expect(result).toMatchObject({
resolve: {
conditions: expectedConditions,
},
Expand All @@ -59,26 +59,26 @@ describe.skipIf(IS_JEST)('vite plugin', () => {

test.each([
{
config: {},
config: () => ({}),
expectedConditions: [],
},
{
config: { resolve: { conditions: [] } },
config: () => ({ resolve: { conditions: [] } }),
expectedConditions: [],
},
{
config: { resolve: { conditions: ['svelte'] } },
config: () => ({ resolve: { conditions: ['svelte'] } }),
expectedConditions: ['svelte'],
},
])(
'skips browser condition if possible',
({ config, expectedConditions }) => {
const subject = svelteTesting()
const viteConfig = deepClone(config)

subject.config(viteConfig)
const result = config()
subject.config(result)

expect(viteConfig).toMatchObject({
expect(result).toMatchObject({
resolve: {
conditions: expectedConditions,
},
Expand All @@ -88,27 +88,27 @@ describe.skipIf(IS_JEST)('vite plugin', () => {

test.each([
{
config: {},
config: () => ({}),
expectedSetupFiles: [expect.stringMatching(/src\/vitest.js$/u)],
},
{
config: { test: { setupFiles: [] } },
config: () => ({ test: { setupFiles: [] } }),
expectedSetupFiles: [expect.stringMatching(/src\/vitest.js$/u)],
},
{
config: { test: { setupFiles: 'other-file.js' } },
config: () => ({ test: { setupFiles: 'other-file.js' } }),
expectedSetupFiles: [
'other-file.js',
expect.stringMatching(/src\/vitest.js$/u),
],
},
])('adds cleanup', ({ config, expectedSetupFiles }) => {
const subject = svelteTesting()
const viteConfig = deepClone(config)

subject.config(viteConfig)
const result = config()
subject.config(result)

expect(viteConfig).toMatchObject({
expect(result).toMatchObject({
test: {
setupFiles: expectedSetupFiles,
},
Expand All @@ -117,28 +117,28 @@ describe.skipIf(IS_JEST)('vite plugin', () => {

test.each([
{
config: { ssr: { noExternal: [] } },
config: () => ({ ssr: { noExternal: [] } }),
expectedNoExternal: ['@testing-library/svelte'],
},
{
config: {},
config: () => ({}),
expectedNoExternal: ['@testing-library/svelte'],
},
{
config: { ssr: { noExternal: 'other-file.js' } },
config: () => ({ ssr: { noExternal: 'other-file.js' } }),
expectedNoExternal: ['other-file.js', '@testing-library/svelte'],
},
{
config: { ssr: { noExternal: /other/u } },
config: () => ({ ssr: { noExternal: /other/u } }),
expectedNoExternal: [/other/u, '@testing-library/svelte'],
},
])('adds noExternal rule', ({ config, expectedNoExternal }) => {
const subject = svelteTesting()
const viteConfig = deepClone(config)

subject.config(viteConfig)
const result = config()
subject.config(result)

expect(viteConfig).toMatchObject({
expect(result).toMatchObject({
ssr: {
noExternal: expectedNoExternal,
},
Expand All @@ -147,24 +147,24 @@ describe.skipIf(IS_JEST)('vite plugin', () => {

test.each([
{
config: { ssr: { noExternal: true } },
config: () => ({ ssr: { noExternal: true } }),
expectedNoExternal: true,
},
{
config: { ssr: { noExternal: '@testing-library/svelte' } },
config: () => ({ ssr: { noExternal: '@testing-library/svelte' } }),
expectedNoExternal: '@testing-library/svelte',
},
{
config: { ssr: { noExternal: /svelte/u } },
config: () => ({ ssr: { noExternal: /svelte/u } }),
expectedNoExternal: /svelte/u,
},
])('skips noExternal if able', ({ config, expectedNoExternal }) => {
const subject = svelteTesting()
const viteConfig = deepClone(config)

subject.config(viteConfig)
const result = config()
subject.config(result)

expect(viteConfig).toMatchObject({
expect(result).toMatchObject({
ssr: {
noExternal: expectedNoExternal,
},
Expand All @@ -173,11 +173,11 @@ describe.skipIf(IS_JEST)('vite plugin', () => {

test('bails on noExternal if input is unexpected', () => {
const subject = svelteTesting()
const viteConfig = deepClone({ ssr: { noExternal: false } })

subject.config(viteConfig)
const result = { ssr: { noExternal: false } }
subject.config(result)

expect(viteConfig).toMatchObject({
expect(result).toMatchObject({
ssr: {
noExternal: false,
},
Expand Down