Skip to content

fix(render): Don't reject wrapper types based on statics #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2021
Merged

fix(render): Don't reject wrapper types based on statics #973

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1510e80
Expected behavior for render#wrapper
eps1lon Oct 3, 2021
a7535eb
fix(render): Don't reject wrapper types based on statics
eps1lon Oct 3, 2021
54057ef
Verify the fix worked for wider props
eps1lon Oct 3, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Expected behavior for render#wrapper
  • Loading branch information
@eps1lon
eps1lon committed Oct 3, 2021
commit 1510e805dc2fb83633c1d1bff51b13f16e92a259
4 changes: 3 additions & 1 deletion types/test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ export function wrappedRenderB(
ui: React.ReactElement,
options?: pure.RenderOptions,
) {
const Wrapper: React.FunctionComponent = ({children}) => {
const Wrapper: React.FunctionComponent<{children?: React.ReactNode}> = ({
Copy link
Member Author

@eps1lon eps1lon Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While FunctionComponent adds implicit children, its propTypes do not so we didn't catch that issue. Here we make sure all statics assume the same props. Also makes sure this doesn't break once we get rid of implicit children in React.FunctionComponent.
children,
}) => {
return <div>{children}</div>
}

Expand Down