Skip to content

Conversation

@gnapse
Copy link
Member

@gnapse gnapse commented Jan 16, 2020

What:

#175 and #182

Why:

#123 and DefinitelyTyped/DefinitelyTyped#37792

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged
gnapse and others added 2 commits December 18, 2019 09:28
BREAKING CHANGE: moving typings to @types/testing-library__jest-dom
@gnapse gnapse requested review from jgoz and kentcdodds January 16, 2020 16:20
@gnapse gnapse mentioned this pull request Jan 16, 2020
4 tasks
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #183 +/- ## ===================================== Coverage 100% 100% ===================================== Files 19 19 Lines 234 234 Branches 57 57 ===================================== Hits 234 234
Impacted Files Coverage Δ
src/extend-expect.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e14dc1...d68ccd7. Read the comment docs.

Copy link
Collaborator

@jgoz jgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me aside from the Readme issue

@jgoz jgoz merged commit 760409a into master Jan 17, 2020
@jgoz jgoz deleted the next branch January 17, 2020 00:00
@gnapse
Copy link
Member Author

gnapse commented Jan 17, 2020

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants