Fix .toHaveTextContent("") causing false positive #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kandros changed the title kandros changed the title kandros force-pushed the fix-toHaveTextContent-empty-string branch from 5dc0e7a to 5fab8a4 Compare 
gnapse approved these changes Oct 7, 2019
| @all-contributors please add @kandros for bug, test |
| I've put up a pull request to add @kandros! 🎉 |
| 🎉 This PR is included in version 4.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What:
fix #104
Why:
It can cause false-positive tests passing
How:
throwing when matching against an empty string, suggesting to use
.toBeEmpty()insteadChecklist: