Skip to content

chore: upgrade @typescript-eslint #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

chore: upgrade @typescript-eslint #852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6443b6
chore: remove `eslint-config-kentcdodds`
lesha1201 Dec 6, 2023
20c87e8
chore: upgrade TypeScript
lesha1201 Dec 6, 2023
9526274
chore!: drop support of unmaintained Node.js versions
lesha1201 Dec 6, 2023
611e827
chore: upgrade `@typescript-eslint`
lesha1201 Dec 6, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: remove eslint-config-kentcdodds 
`eslint-config-kentcdodds` uses some outdated packages which block us from upgrading TypeScript dependencies.
  • Loading branch information
@lesha1201
lesha1201 committed Dec 6, 2023
commit b6443b689218dba7f088ea65dc2df183a9a43e24
32 changes: 31 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
module.exports = {
root: true,
env: {
es6: true,
node: true,
},
extends: [
'kentcdodds',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-config-kentcdodds uses some outdated packages which block us from upgrading TypeScript dependencies properly. It didn't bring many rules so decided just use eslint:recommended, plugin:import/recommended and configure some rules manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change! We should apply it anyway.
'eslint:recommended',
'plugin:import/recommended',
'plugin:jest/recommended',
'plugin:jest-formatting/recommended',
'prettier',
Expand Down Expand Up @@ -33,6 +38,12 @@ module.exports = {
},
},
],
'import/first': 'error',
'import/no-empty-named-blocks': 'error',
'import/no-extraneous-dependencies': 'error',
'import/no-mutable-exports': 'error',
'import/no-named-default': 'error',
'import/no-relative-packages': 'warn',
},
overrides: [
{
Expand All @@ -46,6 +57,7 @@ module.exports = {
extends: [
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'plugin:import/typescript',
],
rules: {
'@typescript-eslint/explicit-function-return-type': 'off',
Expand All @@ -54,6 +66,24 @@ module.exports = {
{ argsIgnorePattern: '^_' },
],
'@typescript-eslint/no-use-before-define': 'off',

// Import
// Rules enabled by `import/recommended` but are better handled by
// TypeScript and @typescript-eslint.
'import/default': 'off',
'import/export': 'off',
'import/namespace': 'off',
'import/no-unresolved': 'off',
},
settings: {
'import/resolver': {
node: {
extensions: ['.js', '.jsx', '.ts', '.tsx'],
},
typescript: {
alwaysTryTypes: true,
},
},
},
},
],
Expand Down
Loading