feat: remove prefer-wait-for rule #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BREAKING CHANGE: remove prefer-wait-for rule
| Hey @skovy, thanks for your contribution! I'm going to create v6 so we can target this PR to that branch. |
| @Belco90 |
MichaelDeBoey changed the title prefer-wait-for rule MichaelDeBoey changed the title prefer-wait-for ruleprefer-wait-for rule 
MichaelDeBoey approved these changes Sep 19, 2022
Even better, thanks for that! |
Belco90 approved these changes Sep 19, 2022
| 🎉 This PR is included in version 6.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MichaelDeBoey added the BREAKING CHANGE MichaelDeBoey pushed a commit that referenced this pull request Oct 4, 2022
BREAKING CHANGE: `prefer-wait-for` is now removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove prefer-wait-for rule since the deprecated helpers were removed
Checks
npm run generate:rules-list)npm run generate:configs)Changes
prefer-wait-forrule since the deprecated helpers were removed fix: Only use a single clock dom-testing-library#966Not sure if there is a
v6oralphabranch?Context
Resolves #627