Skip to content

fix: third round of bug fixes #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2021
Merged

fix: third round of bug fixes #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfa2559
fix(prefer-screen-queries): improve error message
Belco90 Apr 10, 2021
435901a
chore: update package keywords
Belco90 Apr 10, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rules/prefer-screen-queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ export default createTestingLibraryRule<Options, MessageIds>({
meta: {
type: 'suggestion',
docs: {
description: 'Suggest using screen while using queries',
description: 'Suggest using screen while querying',
category: 'Best Practices',
recommended: 'error',
},
messages: {
preferScreenQueries:
'Use screen to query DOM elements, `screen.{{ name }}`',
'Avoid destructuring queries from `render` result, use `screen.{{ name }}` instead',
},
schema: [],
},
Expand Down
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
"keywords": [
"eslint",
"eslintplugin",
"eslint-plugin"
"eslint-plugin",
"lint",
"testing-library",
"testing"
],
"author": {
"name": "Mario Beltrán Alarcón",
Expand Down