fix: add no-await-sync-events exception for userEvent.keyboard #283
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added exception for the new API proposed in testing-library/user-event#581
Note that with the change
userEvent.type
(anduserEvent.keyboard
) will actually return no Promise if thedelay
is not>0
so that the typing and the actual return value will match.Further it might be worth discussing if this rule should be disabled for
.ts
and.tsx
files asts(80007)
and@typescript-eslint/await-thenable
already warn here and curating a manual list has no benefits when there already are warnings based on the type.