Skip to content

Move rules settings to ESLint shared config: refactor no-promise-in-fire-event #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 7, 2020
Merged

Move rules settings to ESLint shared config: refactor no-promise-in-fire-event #266

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dee556f
refactor(await-async-utils): create rule with custom creator
Belco90 Dec 2, 2020
b60b423
test(await-async-utils): remove outdated comment
Belco90 Dec 6, 2020
5cf1d68
docs(no-promise-in-fire-event): improve description and examples
Belco90 Dec 6, 2020
45b8d67
docs(no-promise-in-fire-event): improve invalid errors checks
Belco90 Dec 6, 2020
84cddcb
refactor(no-promise-in-fire-event): use custom rule creator and helpers
Belco90 Dec 6, 2020
bfb8220
feat(no-promise-in-fire-event): detect promise in variable references
Belco90 Dec 7, 2020
74b87e3
docs(no-promise-in-fire-event): update examples
Belco90 Dec 7, 2020
3f1b5e6
test(no-promise-in-fire-event): increase coverage up to 100%
Belco90 Dec 7, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(await-async-utils): create rule with custom creator
  • Loading branch information
@Belco90
Belco90 committed Dec 7, 2020
commit dee556f9f356fa60cd11ecd081ef9640903b729a
2 changes: 2 additions & 0 deletions tests/lib/rules/await-async-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { ASYNC_UTILS } from '../../../lib/utils';

const ruleTester = createRuleTester();

// FIXME: add cases for Promise.allSettled

ruleTester.run(RULE_NAME, rule, {
valid: [
...ASYNC_UTILS.map((asyncUtil) => ({
Expand Down