Skip to content

Move rules settings to ESLint shared config: refactor await-fire-event #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 7, 2020
Merged

Move rules settings to ESLint shared config: refactor await-fire-event #265

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
619b8eb
refactor(await-async-utils): create rule with custom creator
Belco90 Dec 2, 2020
0222ddd
docs(await-fire-event): update description
Belco90 Dec 4, 2020
7fa934d
refactor(await-fire-event): create rule with custom creator
Belco90 Dec 4, 2020
1532804
refactor(await-fire-event): replace manual promise checks by util
Belco90 Dec 4, 2020
4e0a897
refactor: simplify isNodeComingFromTestingLibrary
Belco90 Dec 5, 2020
4d65e1c
fix: call findClosestCallExpressionNode recursively keeping args
Belco90 Dec 5, 2020
16253e5
refactor(prefer-user-event): extract fire event helpers
Belco90 Dec 5, 2020
66ffe9f
refactor(await-async-utils): remove unnecessary as expression
Belco90 Dec 5, 2020
d78cd77
refactor(await-fire-event): reuse fire event detection helpers
Belco90 Dec 6, 2020
1b21106
feat(await-fire-event): detect functions wrapping fire event methods
Belco90 Dec 6, 2020
f9b84f7
fix(await-fire-event): detect more cases
Belco90 Dec 6, 2020
825cbe5
test(await-fire-event): increase coverage
Belco90 Dec 6, 2020
cc33199
docs(await-fire-event): update rule details and examples
Belco90 Dec 6, 2020
ab6da9c
test(await-async-utils): remove outdated comment
Belco90 Dec 6, 2020
20174d0
docs(await-fire-event): update async note
Belco90 Dec 7, 2020
2047b43
style(await-fire-event): format rule doc
Belco90 Dec 7, 2020
ba1628e
refactor(await-fire-event): remove unnecessary check
Belco90 Dec 7, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style(await-fire-event): format rule doc
  • Loading branch information
@Belco90
Belco90 committed Dec 7, 2020
commit 2047b43a10882faa479ecb3adff198e520000e01
1 change: 1 addition & 0 deletions docs/rules/await-fire-event.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This rule aims to prevent users from forgetting to handle promise returned from
methods.

> ⚠️ `fireEvent` methods are async only on following Testing Library packages:
>
> - `@testing-library/vue` (supported by this plugin)
> - `@testing-library/svelte` (not supported yet by this plugin)

Expand Down