feat: add support for multiple test id attributes #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @all-contributors please add @skovy for code, test and doc. |
| I've put up a pull request to add @skovy! 🎉 |
| 🎉 This PR is included in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR proposes adding support for multiple test id attributes (via
testIdAttribute) to theconsistent-data-testidrule.Movitation
When making shared components, some prefer to expose a
testIdprop (example in Atlastkit) in addition to using thedata-testidprop. Ideally, this linting rule could handle more than one test id attribute to handle cases like this.Changes
The configuration was updated to allow either a
string(existing API) or now an array of strings. This was done so the rule continues to work with existing configurations. I also considered adding regex support which could also achieve this and happy to update with that approach if preferred.