Skip to content

Conversation

emmenko
Copy link
Contributor

@emmenko emmenko commented Apr 20, 2020

I noticed that some of the default rules (like for async) don't really work for Cypress, as commands are not promises.

So I thought it would be good to start a default config for Cypress as well.

Comment on lines +42 to +44
rules: {
'testing-library/no-debug': 'warn',
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice here that we don't spread recommendedRules

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should update the comment in Frameworks section within README saying "Note that frameworks configurations enable their specific rules + recommended rules."

@emmenko emmenko requested a review from Belco90 April 20, 2020 14:08
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you started the cypress preset. However, I think we should implement at least the prefer-explicit-assert adaptation for cypress mentioned here. There is an upcoming migration to TS for this repo, I don't know if you prefer to wait until then.

Comment on lines +42 to +44
rules: {
'testing-library/no-debug': 'warn',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should update the comment in Frameworks section within README saying "Note that frameworks configurations enable their specific rules + recommended rules."

@emmenko
Copy link
Contributor Author

emmenko commented Apr 20, 2020

Ah ok, I missed that thread. No problem, let me close this PR then. There is no rush for this.

Thanks :)

@emmenko emmenko closed this Apr 20, 2020
@emmenko emmenko deleted the nm-cypress-config branch April 20, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants