Skip to content

fix(prefer-find-by): ensure autofix wraps findBy* call inside expect(await …) when assertion is involved #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2025
Merged

fix(prefer-find-by): ensure autofix wraps findBy* call inside expect(await …) when assertion is involved #1107

merged 2 commits into from
Oct 28, 2025

Conversation

@y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Oct 23, 2025 •
edited
Loading

Checks

Changes

  • This PR fixes an issue in the prefer-by-findby rule where the autofix incorrectly produced code missing the expect wrapper when an assertion was involved.

Target:

await waitFor(() => expect( screen.getByRole('button', { name: 'Count is: 0' }), ).toBeInTheDocument(), )

Before (incorrect autofix output):

await screen.findByRole('button', { name: 'Count is: 0' })

Expected (correct output):

expect( await screen.findByRole('button', { name: 'Count is: 0' }), ).toBeInTheDocument()

Context

Fixes: #579
@Belco90 Belco90 merged commit 09a9f8c into main Oct 28, 2025
32 checks passed
@Belco90 Belco90 deleted the fix/prefer-find-by branch October 28, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@y-hsgw @Belco90