Skip to content

fix(await-async-events): improveuserEvent.setup() detection #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 22, 2025
Merged

fix(await-async-events): improveuserEvent.setup() detection #1056

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23caac1
fix: flag unhandled async methods called from `setup()` return value
puglyfe Jul 15, 2025
e690b9b
fix: flag unhandled async methods from custom `setup()` calls
puglyfe Jul 15, 2025
63dfaa6
refactor: simplify a bit
puglyfe Jul 23, 2025
347b2cd
Merge branch 'main' into fix-setup-async-methods
puglyfe Aug 2, 2025
338aec2
Merge remote-tracking branch 'origin/main' into fix-setup-async-methods
puglyfe Sep 21, 2025
9180320
fix lint
puglyfe Sep 21, 2025
fbfff97
refactor: remove duplicate util
puglyfe Sep 22, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: remove duplicate util
  • Loading branch information
@puglyfe
puglyfe committed Sep 22, 2025
commit fbfff97f9d0e20a7a8a59f5bbb0fcd8580c5e7a6
20 changes: 3 additions & 17 deletions lib/rules/await-async-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,21 +129,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
);
}

function findFunctionName(node: TSESTree.Node): string | null {
let current: TSESTree.Node | undefined = node;
while (current) {
if (
current.type === AST_NODE_TYPES.FunctionDeclaration ||
current.type === AST_NODE_TYPES.FunctionExpression ||
current.type === AST_NODE_TYPES.ArrowFunctionExpression
) {
return getFunctionName(current);
}
current = current.parent;
}
return null;
}

const eventModules =
typeof options.eventModule === 'string'
? [options.eventModule]
Expand Down Expand Up @@ -221,8 +206,9 @@ export default createTestingLibraryRule<Options, MessageIds>({
}

if (setupProps.size > 0) {
const functionName = findFunctionName(node);
if (functionName) {
const functionNode = findClosestFunctionExpressionNode(node);
if (functionNode) {
const functionName = getFunctionName(functionNode);
setupFunctions.set(functionName, setupProps);
}
}
Expand Down