Skip to content

chore: Migrate ByRole to TypeScript #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 6, 2023
Merged

chore: Migrate ByRole to TypeScript #1186

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4fc28e5
fix: migrate role to ts
DaniAcu Oct 28, 2022
36d53db
fix: remove role model abstraction
DaniAcu Oct 30, 2022
b7e403c
fix: prettier
DaniAcu Oct 30, 2022
3b24e00
fix: force have role that are included in type
DaniAcu Oct 30, 2022
037c073
fix: type
DaniAcu Oct 30, 2022
98568cd
fix: error and add commet ts
DaniAcu Oct 31, 2022
984acb9
fix: any type
DaniAcu Oct 31, 2022
9fab0b8
fix: any type
DaniAcu Oct 31, 2022
82503fb
fix: type assertion
DaniAcu Oct 31, 2022
3de4aa9
fix: ignore branch coverage
DaniAcu Oct 31, 2022
a1fb8c1
fix: typo
DaniAcu Jan 10, 2023
874e769
fix: add hints in all by role
DaniAcu Jan 11, 2023
7431f75
fix: types and comments
DaniAcu Jan 14, 2023
8a3c1a0
fix: restore types
DaniAcu Jan 15, 2023
df14122
fix: restore types
DaniAcu Jan 15, 2023
4423a51
fix: lint
DaniAcu Jan 15, 2023
4de62b3
fix: ts error
DaniAcu Jan 16, 2023
1ea74bd
fix: ts error
DaniAcu Jan 16, 2023
8ae5a9c
fix: type tests
DaniAcu Jan 16, 2023
94163c1
Fix lint
eps1lon Feb 6, 2023
30d44d0
Don't couple query-helpers with ByRole
eps1lon Feb 6, 2023
9e5d4b4
Revert change to ByRoleMatcher type
eps1lon Feb 6, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: typo
  • Loading branch information
@DaniAcu @eps1lon
DaniAcu authored and eps1lon committed Feb 6, 2023
commit a1fb8c13a80e43c2610bd483b75a7e1160776f11
16 changes: 10 additions & 6 deletions src/queries/role.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ import {
computeAccessibleDescription,
computeAccessibleName,
} from 'dom-accessibility-api'
import {roles as allRoles, roleElements, ARIARoleDefintionKey} from 'aria-query'
import {
roles as allRoles,
roleElements,
ARIARoleDefinitionKey,
} from 'aria-query'
import {
computeAriaSelected,
computeAriaChecked,
Expand Down Expand Up @@ -61,7 +65,7 @@ const queryAllByRole: AllByRole = (
if (selected !== undefined) {
// guard against unknown roles
if (
allRoles.get(role as ARIARoleDefintionKey)?.props['aria-selected'] ===
allRoles.get(role as ARIARoleDefinitionKey)?.props['aria-selected'] ===
undefined
) {
throw new Error(`"aria-selected" is not supported on role "${role}".`)
Expand All @@ -71,7 +75,7 @@ const queryAllByRole: AllByRole = (
if (checked !== undefined) {
// guard against unknown roles
if (
allRoles.get(role as ARIARoleDefintionKey)?.props['aria-checked'] ===
allRoles.get(role as ARIARoleDefinitionKey)?.props['aria-checked'] ===
undefined
) {
throw new Error(`"aria-checked" is not supported on role "${role}".`)
Expand All @@ -81,7 +85,7 @@ const queryAllByRole: AllByRole = (
if (pressed !== undefined) {
// guard against unknown roles
if (
allRoles.get(role as ARIARoleDefintionKey)?.props['aria-pressed'] ===
allRoles.get(role as ARIARoleDefinitionKey)?.props['aria-pressed'] ===
undefined
) {
throw new Error(`"aria-pressed" is not supported on role "${role}".`)
Expand All @@ -94,7 +98,7 @@ const queryAllByRole: AllByRole = (
// All currently released ARIA versions support `aria-current` on all roles.
// Leaving this for symetry and forward compatibility
if (
allRoles.get(role as ARIARoleDefintionKey)?.props['aria-current'] ===
allRoles.get(role as ARIARoleDefinitionKey)?.props['aria-current'] ===
undefined
) {
throw new Error(`"aria-current" is not supported on role "${role}".`)
Expand All @@ -109,7 +113,7 @@ const queryAllByRole: AllByRole = (
if (expanded !== undefined) {
// guard against unknown roles
if (
allRoles.get(role as ARIARoleDefintionKey)?.props['aria-expanded'] ===
allRoles.get(role as ARIARoleDefinitionKey)?.props['aria-expanded'] ===
undefined
) {
throw new Error(`"aria-expanded" is not supported on role "${role}".`)
Expand Down