Ensure waitForElement disconnects MutationObserver at the right time #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kentcdodds approved these changes Sep 17, 2018
| 🎉 This PR is included in version 3.5.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What: #99 waitForElement gets into infinite setTimeout loop
Why: without the change MutationObserver gets into infinite setTimeout loop
How: disconnect the MutationObserver from setImmediate callback to ensure we're not in MutationObserver's
onMutatecallback when disconnecting it.Checklist: