Skip to content

Conversation

Hyperxq
Copy link
Contributor

@Hyperxq Hyperxq commented Aug 6, 2024

This pull request if for the issues:
#477
#472

With this change you need to update the documentation. The way to use both is:

ng add @testing-library/angular --install-jest-dom --install-user-event

By default both are in false for this reason, no matter if the users are still using as documentation.

@timdeschryver

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @Hyperxq , I've added a comment

@Hyperxq
Copy link
Contributor Author

Hyperxq commented Aug 6, 2024

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timdeschryver timdeschryver merged commit 641c65f into testing-library:main Aug 6, 2024
@timdeschryver
Copy link
Member

@all-contributors please add @Hyperxq for code

Copy link
Contributor

@timdeschryver

I've put up a pull request to add @Hyperxq! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants