new option on for render and rerender #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great work @mumenthalers !
I left some thoughts, I'm looking forward for your feedback.
cc @lacolaco
mumenthalers changed the title subscribeToOutputs for render and rerenderon for render and rerender 
timdeschryver approved these changes Jul 20, 2024
| @all-contributors please add @mumenthalers for code, tests |
| I've put up a pull request to add @mumenthalers! 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
closes #462
I had to move the
renderFixturefunction up the order, as it's necessary to keep track of thesubscribedOutputsin order to not unnecessarily unsubscribe+resubscribe unchanged listeners whenrerendering.