Skip to content

Conversation

@GregOnNet
Copy link
Contributor

PR for #38

Description
Exposes detectChanges via the render-function allowing to run a change detection cycle.

@GregOnNet GregOnNet changed the title Feat/detect changes feat/detectChanges Sep 2, 2019
@timdeschryver
Copy link
Member

This LGTM, thanks!
Seems like I didn't configure CircleCI to also build PR from forks.
Would you mind to force push and see if the build triggers?

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timdeschryver timdeschryver merged commit 8a6fe17 into testing-library:master Sep 3, 2019
@timdeschryver
Copy link
Member

Thanks @GregOnNet!
Is it OK if I add you as a contributor?

@allcontributors please add @GregOnNet for code

@allcontributors
Copy link
Contributor

@timdeschryver

I could not determine your intention.

Basic usage: @all-contributors please add @jakebolam for code, doc and infra

For other usages see the documentation

@timdeschryver
Copy link
Member

@allcontributors please add @GregOnNet for code

@timdeschryver
Copy link
Member

🎉 This PR is included in version 7.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @GregOnNet! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants