Skip to content

update example specs to standalone #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2023
Merged

update example specs to standalone #400

merged 4 commits into from
Jul 26, 2023

Conversation

markgoho
Copy link
Contributor

@markgoho markgoho commented Jul 12, 2023 •
edited
Loading

fixes #399
@markgoho markgoho force-pushed the update-to-standalone-examples branch from a99f30c to 1e15206 Compare July 12, 2023 15:25
@markgoho markgoho marked this pull request as ready for review July 12, 2023 15:25
LayZeeDK
LayZeeDK reviewed Jul 21, 2023
View reviewed changes
apps/example-app/src/app/app.module.ts Outdated
@NgModule({
declarations: [
AppComponent,
declarations: [AppComponent],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: can the AppComponent not be converted to a standalone component?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid question @LayZeeDK
Ideally, we should also convert this, or just remove it since this project is mainly used for tests (and not to serve it).
What do you think @markgoho ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed these changes, as well as a cleanup of the unnecessary setup/environment files.
timdeschryver
timdeschryver approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markgoho !
@timdeschryver timdeschryver merged commit d36c2ea into testing-library:main Jul 26, 2023
@markgoho
Copy link
Contributor Author

markgoho commented Jul 26, 2023 •
edited
Loading

thank you so much @timdeschryver

I apologize for the delay in response, I was out of the country and couldn't focus the time on this that I wanted to

all the changes you made look fantastic, thanks again!!
@markgoho markgoho deleted the update-to-standalone-examples branch July 26, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@markgoho @LayZeeDK @timdeschryver