Skip to content

Conversation

markgoho
Copy link
Contributor

this closes #394

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like some tests broke with this, could you take a look at it please when you have the time?

@markgoho markgoho force-pushed the update-to-user-event branch from 2540651 to 244906c Compare July 4, 2023 17:03
@markgoho
Copy link
Contributor Author

markgoho commented Jul 9, 2023

It seems like some tests broke with this, could you take a look at it please when you have the time?

So sorry about this! I've fixed all that I could in reasonable amount of time. There were a few that related to fake timers and async stuff that just would not pass.

@markgoho markgoho requested a review from timdeschryver July 11, 2023 18:45
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timdeschryver timdeschryver merged commit 72a4d3c into testing-library:main Jul 12, 2023
@markgoho markgoho deleted the update-to-user-event branch July 12, 2023 14:33
@timdeschryver
Copy link
Member

@all-contributors please add @markgoho for maintenance, docs

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @markgoho! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants