Skip to content

Updated testing-libary.ts #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Updated testing-libary.ts #352

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac523f5
Updated testing-libary.ts
TrustNoOneElse Jan 12, 2023
e4ea9a2
Update Angular peerDependencies to 15.1
TrustNoOneElse Jan 12, 2023
26aefa7
Updated angular-app package.json for build
TrustNoOneElse Jan 13, 2023
7a1701b
Fixed "Maximum call stack" error
TrustNoOneElse Jan 13, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated testing-libary.ts 
Adresses the breaking change which comes trough angular/angular#48114
  • Loading branch information
@TrustNoOneElse
TrustNoOneElse authored Jan 12, 2023
commit ac523f548c33a12d716f02677e2ac0858a814597
8 changes: 4 additions & 4 deletions projects/testing-library/src/lib/testing-library.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
OnChanges,
SimpleChanges,
ApplicationInitStatus,
ɵisStandalone,
isStandalone,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this also works with Angular v15.0 ?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does not work with Angular v15.0 since they introduced this breaking change first at v15.1.
} from '@angular/core';
import { ComponentFixture, TestBed, tick } from '@angular/core/testing';
import { BrowserAnimationsModule, NoopAnimationsModule } from '@angular/platform-browser/animations';
Expand Down Expand Up @@ -321,7 +321,7 @@ function setComponentInputs<SutType>(

function overrideComponentImports<SutType>(sut: Type<SutType> | string, imports: (Type<any> | any[])[] | undefined) {
if (imports) {
if (typeof sut === 'function' && ɵisStandalone(sut)) {
if (typeof sut === 'function' && isStandalone(sut)) {
TestBed.overrideComponent(sut, { set: { imports } });
} else {
throw new Error(
Expand Down Expand Up @@ -369,7 +369,7 @@ function addAutoDeclarations<SutType>(
return [...declarations, wrapper];
}

const components = () => (excludeComponentDeclaration || ɵisStandalone(sut) ? [] : [sut]);
const components = () => (excludeComponentDeclaration || isStandalone(sut) ? [] : [sut]);
return [...declarations, ...components()];
}

Expand All @@ -384,7 +384,7 @@ function addAutoImports<SutType>(
};

const routing = () => (routes ? [RouterTestingModule.withRoutes(routes)] : []);
const components = () => (typeof sut !== 'string' && ɵisStandalone(sut) ? [sut] : []);
const components = () => (typeof sut !== 'string' && isStandalone(sut) ? [sut] : []);
return [...imports, ...components(), ...animations(), ...routing()];
}

Expand Down