chore: improve dependencies #277
Conversation
…vDependencies @angular/forms and @testing-library/user-event are only used in tests and should not be exported in the package.json for production. @see: testing-library#272 (comment)
We should use the workspace.json and project.json files
Upgrade ESLint and eslint dependencies
NX does not support > 5.3.0 yet
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Set outdir to the same as testing-library and the way NX has as default.
…ependencies' into chore/use-workspace-and-proper-dependencies
| Thanks for the great review and suggestions @timdeschryver 👍 |
Which line/bug are you referring to? 😇 |
| "@angular-eslint/template-parser": "13.0.1", | ||
| "@angular/cli": "13.1.2", | ||
| "@angular/compiler-cli": "13.1.1", | ||
| "@angular/forms": "13.1.1", |
There was a problem hiding this comment.
@timdeschryver
The 'fix' / prevent @angular/forms and @testing-library/user-event being exported in the generated package.json I moved them to the devDependencies, since they are only used in 'dev' -> tests
don't think it is fixed in NX yet -> nrwl/nx#8096
https://github.com/testing-library/angular-testing-library/pull/277/files#r780759922 |
| 🎉 This PR is included in version 11.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
fix for using the proper dependencies AND using NX per-project-configuration
@see
Fix:
New generated
package.json{ "name": "@testing-library/angular", "version": "0.0.0-semantically-released", "description": "Test your Angular components with the dom-testing-library", "repository": { "type": "git", "url": "git+https://github.com/testing-library/angular-testing-library.git" }, "keywords": [ "angular", "ngx", "ng", "typescript", "angular2", "test", "dom-testing-library" ], "author": "Tim Deschryver", "license": "MIT", "bugs": { "url": "https://github.com/testing-library/angular-testing-library/issues" }, "homepage": "https://github.com/testing-library/angular-testing-library#readme", "schematics": "./schematics/collection.json", "ng-add": { "save": "devDependencies" }, "ng-update": { "migrations": "./schematics/migrations/migration.json" }, "peerDependencies": { "@angular/common": ">= 13.0.0", "@angular/platform-browser": ">= 13.0.0", "@angular/router": ">= 13.0.0", "@angular/core": ">= 13.0.0", "rxjs": ">= 7.4.0" }, "dependencies": { "@testing-library/dom": "^8.0.0", "tslib": "^2.3.1" }, "publishConfig": { "access": "public" }, "module": "fesm2015/testing-library-angular.mjs", "es2020": "fesm2020/testing-library-angular.mjs", "esm2020": "esm2020/testing-library-angular.mjs", "fesm2020": "fesm2020/testing-library-angular.mjs", "fesm2015": "fesm2015/testing-library-angular.mjs", "typings": "testing-library-angular.d.ts", "exports": { "./package.json": { "default": "./package.json" }, ".": { "types": "./testing-library-angular.d.ts", "esm2020": "./esm2020/testing-library-angular.mjs", "es2020": "./fesm2020/testing-library-angular.mjs", "es2015": "./fesm2015/testing-library-angular.mjs", "node": "./fesm2015/testing-library-angular.mjs", "default": "./fesm2020/testing-library-angular.mjs" } }, "sideEffects": false }