Skip to content

chore(lint): re-enable eslint plugin angular #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 7, 2021
Merged

chore(lint): re-enable eslint plugin angular #237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
230c1a1
build(lint): re-add eslint-plugins
Jul 6, 2021
faf5d96
fix(lint): apply linting autofix
Jul 6, 2021
8440fd8
fix(lint): fix linting errors
Jul 6, 2021
c8786e8
build(deps): update (es)linting dependencies
Jul 6, 2021
2ac614b
chore(example-app): add ScrollingModule to AppModule
Jul 6, 2021
4788459
build(lint): adjust settings for eslint
Jul 6, 2021
2ddaaca
fix(lint): fix additional linting errors
Jul 6, 2021
122c6c1
refactor(fire-event): extract fixture from render
Jul 6, 2021
49d43d0
build(karma): add jasmine plugins
Jul 6, 2021
2197583
fix(lint): include all files from example-app-karma
Jul 6, 2021
41bb00f
refactor(find-by-text): use utility functions instead of screen
Jul 7, 2021
d74e306
refactor(render): use utility functions instead of screen
Jul 7, 2021
3100e15
Apply suggestions from code review
timdeschryver Jul 7, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build(lint): adjust settings for eslint 
Following the guide https://github.com/testing-library/eslint-plugin-testing-library#run-the-plugin-only-against-test-files
  • Loading branch information
arjen.althoff committed Jul 6, 2021
commit 47884598ac35992e3300b0b93623cb68212b92d1
9 changes: 8 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"root": true,
"ignorePatterns": ["**/*"],
"plugins": ["@nrwl/nx"],
"plugins": ["@nrwl/nx", "testing-library"],
"overrides": [
{
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
Expand Down Expand Up @@ -109,6 +109,13 @@
{
"files": ["*.ts", "*.js"],
"extends": ["prettier"]
},
{
"files": ["*.spec.ts"],
"extends": ["plugin:testing-library/angular"],
"rules": {
"testing-library/prefer-explicit-assert": "error"
}
}
]
}
8 changes: 1 addition & 7 deletions apps/example-app/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,8 @@
"env": {
"jest": true
},
"extends": [
"plugin:jest/recommended",
"plugin:jest/style",
"plugin:testing-library/angular",
"plugin:jest-dom/recommended"
],
"extends": ["plugin:jest/recommended", "plugin:jest/style", "plugin:jest-dom/recommended"],
"rules": {
"testing-library/prefer-explicit-assert": "error",
"jest/consistent-test-it": ["error"],
"jest/expect-expect": "off"
}
Expand Down
11 changes: 11 additions & 0 deletions projects/jest-utils/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@
]
}
},
{
"files": ["*.spec.ts"],
"env": {
"jest": true
},
"extends": ["plugin:jest/recommended", "plugin:jest/style", "plugin:jest-dom/recommended"],
"rules": {
"jest/consistent-test-it": ["error"],
"jest/expect-expect": "off"
}
},
{
"files": ["*.html"],
"extends": ["plugin:@nrwl/nx/angular-template"],
Expand Down
8 changes: 1 addition & 7 deletions projects/testing-library/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,8 @@
"env": {
"jest": true
},
"extends": [
"plugin:jest/recommended",
"plugin:jest/style",
"plugin:testing-library/angular",
"plugin:jest-dom/recommended"
],
"extends": ["plugin:jest/recommended", "plugin:jest/style", "plugin:jest-dom/recommended"],
"rules": {
"testing-library/prefer-explicit-assert": "error",
"jest/consistent-test-it": ["error"],
"jest/expect-expect": "off"
}
Expand Down