Skip to content

Switch Debug Flag from int to bool #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

Switch Debug Flag from int to bool #53

merged 2 commits into from
Jul 20, 2023

Conversation

@kaypee90
Copy link
Contributor

@kaypee90 kaypee90 commented Aug 16, 2022

resolves #50
@mjhea0 mjhea0 merged commit 5ebc9ed into testdrivenio:master Jul 20, 2023
@954-Ivory
Copy link

954-Ivory commented Aug 19, 2023 •
edited
Loading

Please review this PR.

This PR is error.
When we set the DEBUG=0 in envs file, we will get a str type: '0'.

bool(os.environ.get("DEBUG", '0')) # This will be True

So, we need change it to:

bool(int(os.environ.get("DEBUG", default=0)))

#50 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@kaypee90 @954-Ivory @mjhea0