feat(asm): Adding CA option without providing CA_CERT maps and adding revision_name flag #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…t providing the four maps.
christopher-hendrich-sada requested review from a team, Jberlinsky and bharathkkb as code owners adding missed variable in line 207 and 211
correcting REVISION_NAME_COMMAND_SNIPPET variable in line 211
| Thanks for the PR! 🚀 |
morgante changed the title Ca and rev name
Fixed a missing bracket
… --ca_certs flag, to use self-signed certificate
bharathkkb requested changes Jul 20, 2021
Member
bharathkkb left a comment
bharathkkb left a comment There was a problem hiding this comment.
Thanks for the PR @christopherhendrich
Some lint related issues #952 (comment) here
I assume we can also remove the bash CA_COMMAND* since with validation only all or none will be allowed?
Contributor Author
| Hi @bharathkkb, In regards to the CA_COMMAND, do you mean line 182-186 in install_asm.sh? I think that is still needed, because you want to be able to run just the '--ca citadel' flag or the flag and the ca_certs maps or no --ca flag to use meshca. |
bharathkkb reviewed Jul 21, 2021
…g {} around single digits numbers for line 24-32, adding echos for CA variables. …aform-google-kubernetes-engine into ca-and-rev-name
bharathkkb approved these changes Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is to align the tf module with the install_asm script as used for Citadel to MeshCA in the official documentation: https://cloud.google.com/service-mesh/docs/ca-migration
It adds the --revision_name flag, so we can deploy a second ASM control plane of the same ASM version using a unique revision name.
It also lets you deploy ASM without specifying the maps for --ca_certs. If you only specify, --ca citadel, it will now deploy successfully.