Skip to content

fix: wait-for-cluster fallback filter to name if location is not set #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix: wait-for-cluster fallback filter to name if location is not set #736

merged 1 commit into from
Nov 5, 2020

Conversation

@bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Nov 3, 2020

fixes #735

  • fallback to just using name in the filter if location is not set for destroy hook
@bharathkkb bharathkkb requested review from a team and Jberlinsky as code owners November 3, 2020 21:13
@comment-bot-dev
Copy link

comment-bot-dev commented Nov 3, 2020 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.
@bharathkkb bharathkkb merged commit 63d7f5e into master Nov 5, 2020
@bharathkkb bharathkkb deleted the fallback-wait-for-cluster branch November 5, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@bharathkkb @comment-bot-dev @morgante