Add secure boot and integrity monitoring documentation #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…te-variant README.md
c0ffeec0der requested review from a team, Jberlinsky and bharathkkb as code owners 
morgante suggested changes May 20, 2020
| The code in autogen was updated in #506. And i ran make build. But documentation was not updated by the tool. This pull request is manual update. I have also tried make generate_docs. Nothing changed in readme.md …On Wed, May 20, 2020, 10:17 PM Morgante Pell ***@***.***> wrote: ***@***.**** requested changes on this pull request. Please make this change in autogen/. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#525 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APNPOIQJOECEB73HBEYFFJDRSPX77ANCNFSM4NFXKKJQ> . |
| The code was updated, but the README is also autogenerated for the different modules: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blame/master/autogen/main/README.md#L170 You'll need to update it there then run |
…te-variant README.md
| Ah, alright. I have updated README.md in /autogen Note: I see there's a lot of unrelevant changes made by the tool. It could be from someone else work but have not run make build? I have only pushed the changes for secure boot and integrity monitoring documentation |
…te-variant README.md
morgante approved these changes May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add secure boot and integrity monitoring in beta-private-cluster-update-variant README.md
Resolve: #501