Skip to content

Conversation

ghabian
Copy link
Contributor

@ghabian ghabian commented Dec 14, 2023

making a separate PR to attempt to fix issues with #1672 adding support for dual stack GKE clusters (by @jmymy )
fixes:
#1656
#1602

@ghabian ghabian requested review from a team and ericyz as code owners December 14, 2023 21:53
@ghabian ghabian marked this pull request as draft December 14, 2023 22:10
@bharathkkb
Copy link
Member

/gcbrun

@ghabian ghabian changed the title Add dual stack beta feat: dual stack (IPV4_IPV6) support Dec 15, 2023
@ghabian
Copy link
Contributor Author

ghabian commented Dec 15, 2023

/gcbrun

1 similar comment
@bharathkkb
Copy link
Member

/gcbrun

@ghabian
Copy link
Contributor Author

ghabian commented Dec 16, 2023

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

@ghabian
Copy link
Contributor Author

ghabian commented Dec 18, 2023

note: The PR is in draft I'm just making sure the new URL for the ACM policy bundle is correct (cc: @apeabody ). otherwise the code should be ready for review (if one is needed)

@apeabody
Copy link
Collaborator

/gcbrun

@ghabian ghabian marked this pull request as ready for review December 19, 2023 00:00
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody requested a review from bharathkkb December 28, 2023 16:42
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ghabian!

@apeabody apeabody merged commit d6cb390 into terraform-google-modules:master Jan 3, 2024
@ghabian ghabian deleted the add-dual-stack-beta branch February 1, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants