Skip to content

fix: set only one of log/mon config or service #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2022
Merged

fix: set only one of log/mon config or service #1240

merged 4 commits into from
May 3, 2022

Conversation

@bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented May 3, 2022

API only permits either logging/monitoring_service or logging/monitoring_config. Also added a test.

fixes #1144
@bharathkkb bharathkkb requested review from a team and Jberlinsky as code owners May 3, 2022 00:13
@comment-bot-dev
Copy link

comment-bot-dev commented May 3, 2022 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.
@morgante morgante merged commit 2316e77 into master May 3, 2022
@release-please release-please bot mentioned this pull request May 3, 2022
Merged
@bharathkkb bharathkkb deleted the fix-log-mon branch May 4, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@bharathkkb @comment-bot-dev @morgante