ASM module rewrite improvements #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Monkeyanator requested review from a team, Jberlinsky and bharathkkb as code owners 
morgante approved these changes Mar 4, 2022
| Thanks for the PR! 🚀 |
bharathkkb reviewed Mar 8, 2022
Member
bharathkkb left a comment
bharathkkb left a comment There was a problem hiding this comment.
Can we remove this https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/examples/simple_zonal_with_asm/hub.tf and use the new flags instead?
Monkeyanator force-pushed the asm-improvements branch from 5c1b682 to 007fbca Compare 
Author
Done, thanks |
Member
| @Monkeyanator Looks like some ASM tests may need an update |
morgante approved these changes Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1164. Adds the
enable_fleet_registrationandenable_mesh_featurevariables, documents a best-effort upgrade path from the previous module