feat: Support passing extra args to poetry export #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
morganchorlton3 changed the title 
| How about simplifying things a bit, and just accept a |
| Hi @pdecat yeah I can make that change |
Change applied 👍 |
pdecat reviewed Jun 11, 2024
pdecat reviewed Jun 11, 2024
pdecat reviewed Jun 11, 2024
| PR should be renamed, e.g. |
antonbabenko changed the title antonbabenko pushed a commit that referenced this pull request Jun 12, 2024
## [7.6.0](v7.5.0...v7.6.0) (2024-06-12) ### Features * Support passing extra args to poetry export ([#584](#584)) ([3aa288f](3aa288f))
| This PR is included in version 7.6.0 🎉 |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
I have added support to pass additional poetry arguments into the source paths
{ path = "../pyproject.toml" poetry_install = true additional_poetry_args= ["--with", "dev", ...] }closes #500
Motivation and Context
I have a project with a mono-repo approach with multiple lambda functions in the project, I have some separate list of dependencies defined in my pyproject.toml. I want to install additional dependencies for certain lambda functions for example
Lambda function 1 deps:
...
Lambda function 2 deps:
....
Common function deps:
....
I could then install the common deps for all lambda functions and then install specific deps for each lambda functions.
Breaking Changes
None that i am aware off
How Has This Been Tested?
examples/*to demonstrate and validate my change(s) (I can do this if it would help, what would be the best to update/ should i add a new example?)I have tested these changes locally with a local project deploying a lambda with and without groups defined
I am happy to do additional testing if required.
pre-commit run -aon my pull request (see screenshot)