fix: Update lookup logic for Atlantis URL due to variable optional attributes #428
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
try(var.atlantis.fqdn, module.alb.route53_records["A"].fqdn, null),asnullwhen not providing afqdnbecause of the variable optional attributes (does not fall back to the next value on error, no error provided - justnull). This coupled with the overallcoalesce()means that the ALB DNS name is commonly exported instead of the URL using the Route53 record created by the moduleBreaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request