Skip to content

Conversation

@bryantbiggs
Copy link
Member

Description

  • Update lookup logic for Atlantis URL due to variable optional attributes

Motivation and Context

  • The current logic will resolve try(var.atlantis.fqdn, module.alb.route53_records["A"].fqdn, null), as null when not providing a fqdn because of the variable optional attributes (does not fall back to the next value on error, no error provided - just null). This coupled with the overall coalesce() means that the ALB DNS name is commonly exported instead of the URL using the Route53 record created by the module

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
@bryantbiggs bryantbiggs merged commit fd00ee1 into terraform-aws-modules:master Nov 12, 2025
9 checks passed
@bryantbiggs bryantbiggs deleted the fix/url branch November 12, 2025 00:00
antonbabenko pushed a commit that referenced this pull request Nov 12, 2025
## [5.0.2](v5.0.1...v5.0.2) (2025-11-12) ### Bug Fixes * Update lookup logic for Atlantis URL due to variable optional attributes ([#428](#428)) ([fd00ee1](fd00ee1))
@antonbabenko
Copy link
Member

This PR is included in version 5.0.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants