feat: Add support for different name for EFS #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Andrews-repo changed the title Andrews-repo changed the title 
bryantbiggs approved these changes Jan 18, 2024
bryantbiggs changed the title 
antonbabenko pushed a commit that referenced this pull request Jan 18, 2024
## [4.2.0](v4.1.0...v4.2.0) (2024-01-18) ### Features * Add support for different name for EFS ([#392](#392)) ([bf31af0](bf31af0))
Member
| This PR is included in version 4.2.0 🎉 |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
The logic to name EFS was added, but it is tied to the main "name" variable for the module, and does not contain the logic to allow for uniques names when passing them in differently.
Motivation and Context
Declaring a unique name in the EFS array did not allow for setting unique names. Default/unique name for the module was applied from the Atlantis module.