This repository was archived by the owner on Sep 17, 2022. It is now read-only.
Revert package_name in package.json after install #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The field
package_namein package.json file is only used when downloading pre-compiled node addon. The value (such as CPU-darwin-1.2.5.tar.gz) is different for each platform, package version, and cpu/gpu.During development, the value might be change when developers switch platforms and the change is included in PR, which is confusing for reviewers.
This PR will make the field
package_namea temp field during installation and will be removed after installation. So the change will not be included in PRs.Fix: tensorflow/tfjs#1756
This change is