Skip to content

Embedding Projector: remove knn gpu splitting #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alicialics wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Embedding Projector: remove knn gpu splitting #6275

alicialics wants to merge 1 commit into from

Conversation

@alicialics
Copy link
Contributor

@alicialics alicialics commented Mar 26, 2023 •
edited
Loading

  • Motivation for features / changes

Splitting an arbitrary vector into 256 parts hurts performance. This change speeds up KNN computation by 3x-5x.
The splitting needs to be done before matrix multiplication step for the cosine similarity computation. Splitting at knn step is already too late. The matrix limit is 2^13 x 2^13 on firefox and 2^14 x 2^14 on chrome (gl.MAX_TEXTURE_SIZE)

  • Technical description of changes
    Remove all code that relates to GPU splitting

  • Screenshots of UI changes

  • Detailed steps to verify changes work correctly (as executed by you)
    Ran vz_projector_test

  • Alternate designs / implementations considered
@alicialics alicialics changed the title Tensor Board: remove knn gpu splitting Embedding Projector: remove knn gpu splitting Apr 4, 2023
This was referenced Apr 5, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin:projector

2 participants

@alicialics @nfelt