Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Conversation

EmilsOzolins
Copy link
Contributor

When target dimensions are not known, use hparams.max_length. max_length should be a power of 2.
Max length can be enforced using hparams.force_max_length=True.
Auto-Regressive decoding not supported at this moment.

When target dimensions are not known use hparams.max_length. max_length should be power of 2. Max length can be enforced using hparams.force_max_length=True. Auto-Regressive decoding not supported at this moment.
@googlebot googlebot added the cla: yes PR author has signed CLA label Jan 29, 2020
@dfurrer
Copy link
Contributor

dfurrer commented Jan 31, 2020

I get the following linter error (and a crash when trying to run). Could you fix this in the request please?

third_party/py/tensor2tensor/models/research/shuffle_network.py: 364: Type annotations not enabled. (<string>, line 364) [syntax-error]

@EmilsOzolins
Copy link
Contributor Author

I hope this solves the problem.

@dfurrer
Copy link
Contributor

dfurrer commented Jan 31, 2020

Thanks. I have it running and the decode calls seem to work. However the linter now complains about these:
347: There should not be a space before a one-line docstring summary [g-space-before-docstring-summary]
347: One-line docstring summary should be followed by a blank line [g-no-space-after-docstring-summary]
389: There should not be a space before a one-line docstring summary [g-space-before-docstring-summary]
389: One-line docstring summary should be followed by a blank line [g-no-space-after-docstring-summary]
389: Missing Returns section in docstring, or wrong choice of Returns/Yields [g-doc-return-or-yield]

@EmilsOzolins
Copy link
Contributor Author

Fixed those errors as well.

@afrozenator
Copy link
Contributor

Many thanks to @OptimatiumFeles and @dfurrer both!

@afrozenator afrozenator merged commit ab9fb79 into tensorflow:master Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed CLA

4 participants