fix: move openexr to runtime dependency #691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| @nkovela1 can we maybe get this merged? If it needs to be, I can also become a maintainer of the repo to help with PRs This is actively preventing people from installing the package, unfortunately |
Contributor
| I will defer to @G4G on this, as he is the owner of the TF graphics repo. |
G4G approved these changes Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
OpenEXR is meant to be an optional dependency as raised in #421.
Moved it away from the requirements.txt (where it probably never should have been) and added a runtime check for the import and version.
Alternatively, having extras like [dev] or [openexr] in the requirements could be a step forward, in general, to make this better manageable.