KO: add site/ko/swift/python_interoperability.ipynb #1062

FKgk · 2019-10-01T04:02:31Z

added swift tutorial is korean translation of swift/docs/site/tutorials/python_interoperability.ipynb

tfdocsbot · 2019-10-01T04:02:36Z

Preview and run these notebook edits with Google Colab:

site/ko/swift/python_interoperability.ipynb

Notebook diffs available on ReviewNB.com.

tfdocsbot · 2019-10-01T04:02:37Z

Reviewers added, please take a look.
@rickiepark, @cre8tor, @Choiuijin1125, @JKIsaacLee, @NoelBird

When your review is finished, approve the pull request or include "LGTM" in your comment.

wckim

Hi @FKgk

It's a great translation.
Most sentences are reasonable.
Please check my comments. :)

Thank you!

wckim · 2019-10-01T04:40:30Z

site/ko/swift/python_interoperability.ipynb

+ "source": [
+ "# 파이썬 상호 호환성\n",
+ "\n",
+ "텐서플로우를 위한 스위프트는 파이썬 상호 호환성을 지원합니다.\n",


'tensorflow' is translated as '텐서플로' in TF docs.
Please replace '텐서플로우' with '텐서플로'.

Thank you for review

I changed it from '텐서플로우' to '텐서플로'.

wckim · 2019-10-01T04:45:00Z

site/ko/swift/python_interoperability.ipynb

+ "metadata": {},
+ "source": [
+ "_노트: \n",
+ "파이썬을 임포트한 직후, 파이썬 코드를 호출하기 전에`PythonLibrary.useVersion`을 실행해야 합니다._\n"


'Note' is a style element used on tensorflow.org for callout boxes. So, don't need to translate the word.
I suggest to replace '_노트' with 'Note'

I changed it from '노트' to 'Note'
Also 267th line was changed same.

wckim · 2019-10-01T04:48:16Z

site/ko/swift/python_interoperability.ipynb

+ "cell_type": "markdown",
+ "metadata": {},
+ "source": [
+ "`PYTHON_LOADER_LOGGING=1` 설정은 [debug output for Python library loading](https://github.com/apple/swift/pull/20674#discussion_r235207008)을 참고하세요."


The words for site link, 'debug... loading', seems to be translated.

I translate it from 'debug output for Python library loading' to '파이썬 라이브러리 로딩을 위한 디버그 출력'
Or should I not translate?

wckim · 2019-10-01T04:52:03Z

site/ko/swift/python_interoperability.ipynb

+ },
+ "source": [
+ "## 기본\n",
+ "스위프트에서, `PythonObject`는 파이썬에서 객체를 나타냅니다.\n",


'~에서' ... '~에서' doesn't looks natural.
I suggest to replace '파이썬에서' with '파이썬'

I changed it from '파이썬에서' to '파이썬
And I suggest to replace '스위프트에서,' with '스위프트에서'
(But the en doc says 'in swift,' )

wckim · 2019-10-01T04:58:18Z

site/ko/swift/python_interoperability.ipynb

+ "* `변할 수 있는 수집`\n",
+ "* `리터럴에 의해 표현가능한` 모든 프로토콜\n",
+ "\n",
+ "노트: 이러한 형식은 안전하지 않습니다.\n",


In the original English document, the word, 'Note', is not used but 'Note that'.
'Note' is a style element but not 'Note that'.
I suggest to rewrite this sentence.

I suggest to rewrite '노트: 이러한 형식은 안전하지 않습니다.' with '이러한 형식은 안전하지 않다는 점에 유의해야 합니다.'

wckim · 2019-10-01T05:17:34Z

site/ko/swift/python_interoperability.ipynb

+ }
+ ],
+ "source": [
+ "// `Python.builtins`은 모든 파이썬 내장객체의 딕셔너리입니다.\n",


Just typo '내장객체' -> '내장 객체'

I Correctly fixed. ('내장객체' -> '내장 객체')

wckim · 2019-10-01T05:21:07Z

site/ko/swift/python_interoperability.ipynb

+ "// `Python.builtins`은 모든 파이썬 내장객체의 딕셔너리입니다.\n",
+ "_ = Python.builtins\n",
+ "\n",
+ "// 파이썬 내장 객체를 시도합니다.\n",


The literal translation of 'Try' seems to be not good.
I suggest to replace '시도합니다' with '사용합니다.'

I replaced it from '시도합니다.' to '사용합니다.'

wckim · 2019-10-01T05:23:46Z

site/ko/swift/python_interoperability.ipynb

+ "- `Array<Element>`\n",
+ "- `ShapedArray<Scalar>`\n",
+ "- `Tensor<Scalar>`\n",
+ "\n",


Line 487-491 is the English document and should be removed.

I remove them

wckim · 2019-10-01T05:29:05Z

site/ko/swift/python_interoperability.ipynb

+ "source": [
+ "## 이미지 표시\n",
+ "\n",
+ "파이썬 노트북에서처럼 `matplotlib`를 이용해 이미지를 일렬로 표시할 수 있습니다."


In this case, the meaning of 'in-line' might be 'same-line', 'same-page' or 'output line'
I suggest to replace '일렬로' with '같은 화면에' or '결과창에'.

I changed it '일렬로' to '결과 창에'

Thank you for information

wckim · 2019-10-01T05:29:47Z

site/ko/swift/python_interoperability.ipynb

+ }
+ ],
+ "source": [
+ "// 세트 업.\n",


I suggest to replace '세트 업' with '준비'.

I changed it from '세트 업' to '준비'

Thank you for letting me know about many changes.
After this translation, I will try to be better next time I participate.

lamberta · 2019-10-01T16:32:09Z

site/ko/swift/python_interoperability.ipynb

+ "toc_visible": true,
+ "version": "0.3.2"
+ },
+ "kernelspec": {


Swift notebooks are a bit different than Python notebooks. You need to manually set the kernel to use Swift in Colab (there's not a UI option, yet).

See the original notebook (at the bottom): https://raw.githubusercontent.com/tensorflow/swift/master/docs/site/tutorials/python_interoperability.ipynb

I would recommend starting a translation by copying that notebook instead of starting a new one. These should execute in Colab.

Meta data has been modified for Swift.

Perhaps the kernel changed while checking on local notebook after work in colab

Thank you

wckim

Thank you for your great translation. 👍
My review is almost finished.
My final suggestion is, after checking all comments, carefully review the final version yourself to keep tone and manner.

wckim · 2019-10-28T01:15:03Z

site/ko/swift/python_interoperability.ipynb

+ "colab_type": "text"
+ },
+ "source": [
+ "Note: 이 문서는 텐서플로 커뮤니티에서 번역했습니다. 커뮤니티 번역 활동의 특성상 정확한 번역과 최신 내용을 반영하기 위해 노력함에도 불구하고 [공식 영문 문서](https://github.com/tensorflow/docs/blob/master/site/en/guide/distribute_strategy.ipynb)의 내용과 일치하지 않을 수 있습니다. 이 번역에 개선할 부분이 있다면 [tensorflow/docs](https://github.com/tensorflow/docs) 깃허브 저장소로 풀 리퀘스트를 보내주시기 바랍니다. 문서 번역이나 리뷰에 참여하려면 [docs-ko@tensorflow.org](https://groups.google.com/a/tensorflow.org/forum/#!forum/docs-ko)로 메일을 보내주시기 바랍니다."


Please change the "[공식 영문 문서]" link into your original document.

I changed url link
Thanks

wckim · 2019-10-28T01:17:52Z

site/ko/swift/python_interoperability.ipynb

+ "source": [
+ "# 파이썬 상호 호환성\n",
+ "\n",
+ "텐서플로를 위한 스위프트는 파이썬 상호 호환성을 지원합니다.\n",


To read easily, I suggest "파이썬 상호 호환성을 지원합니다." -> "파이썬과 상호 호환됩니다."

As suggested, the sentence was reflected.
Thanks

wckim · 2019-10-28T01:20:42Z

site/ko/swift/python_interoperability.ipynb

+ },
+ "source": [
+ "기본적으로 파이썬을 임포트 하면, 스위프트는 시스템 라이브러리 경로에 따라 설치된 최신 버전의 파이썬을 검색합니다.\n",
+ "특정한 파이썬을 설치하고자 할 때, `PYTHON_LIBRARY` 환경변수에 설치시 제공받은 `libpython` 공유 라이브러리를 설정합니다. 예를 들어:\n",


To read easily, I suggest "설치하고자 할 때" -> " 설치하려면"

As suggested, the sentence was reflected.
Thanks.

wckim · 2019-10-28T01:24:01Z

site/ko/swift/python_interoperability.ipynb

+ "source": [
+ "또는 스위프트가 시스템 라이브러리 경로에서 알맞은 파이썬 버전을 찾도록 해서 `PYTHON_VERSION` 환경변수를 설정할 수 있습니다. `PYTHON_LIBRARY`가 `PYTHON_VERSION`보다 우선한다는 점을 유의해야 합니다.\n",
+ "\n",
+ "또한 코드에서 `PYTHON_VERSION` 설정과 동일한 `PythonLibrary.useVersion`함수를 호출할 수 있습니다."


For readability, Please add "기능을 하는" after "동일한".

I add "기능을 하는" after "동일한"
Thanks

wckim · 2019-10-28T01:29:35Z

site/ko/swift/python_interoperability.ipynb

+ "id": "w3lmTRCWT5sS"
+ },
+ "source": [
+ "튜플을 파이썬에서 스위프트로 변환하려면, 정적으로 튜플의 길이를 알아야 합니다.\n",


To read easily in Korean, I suggest "정적으로 튜플의 길이" -> "정확한 튜플 크기".

As suggested, the sentence was reflected.
I changed from "정적으로" to "정확한
Thanks

FKgk · 2019-10-28T15:11:29Z

Thank you for your excellent and accurate review.
We will soon proceed with the final review.

wckim · 2019-10-29T05:04:54Z

@FKgk please let me know when you are done with your final review.

FKgk · 2019-10-29T06:20:21Z

Yes, I'll tell you as soon as the end of the review.

FKgk · 2019-10-31T04:41:10Z

@wckim I've finished my final review.
Thank you for your review so far.

wckim · 2019-10-31T08:01:13Z

@FKgk Thank you for your great contribution to Korean translation of TensorFlow. 👍
LGTM

cre8tor · 2019-10-31T11:54:56Z

LGTM 👍
Thank you for your contribution

FKgk · 2019-11-10T05:00:51Z

@lamberta Thanks for waiting
I got an LGTM, could you merge it?

MarkDaoust

Thanks.

PiperOrigin-RevId: 279790594

FKgk added 2 commits October 1, 2019 12:41

add site/ko/swift/python_interoperability.ipynb

af04a90

translate from en to ko

39fade6

FKgk requested review from MarkDaoust and lamberta as code owners October 1, 2019 04:02

googlebot added the cla: yes CLA has been signed label Oct 1, 2019

tfdocsbot added ko translation Community-provided translation for certain languages labels Oct 1, 2019

wckim reviewed Oct 1, 2019

View reviewed changes

FKgk added 17 commits October 1, 2019 18:42

텐서플로우 -> 텐서플로

33dc8fb

노트 -> Note

527ee2f

파이썬에서 -> 파이썬

5e365e3

노트 -> Note

561903a

내장객체 -> 내장 객체

60ae220

튜플의 열성 -> 튜플의 열성

a913e36

방법 -> 메서드

be24958

Python -> 파이썬 & 진입합니다. -> 접근합니다.

8b0af42

시도합니다. -> 사용합니다.

4a33694

세트 업. -> 준비.

8873b44

일렬로 -> 결과창에

1e33f91

remove English Document

01503fc

스위피트에서, -> 스위프트에서

d9bdb60

투플 -> 튜플

1179962

결과창에 -> 결과 창에

4c359a2

노트: ~ 않습니다. -> ~ 않다는 점에 유의해야 합니다

4f44aaa

debug ... loading -> 파이썬 라이브러리 로딩을 위한 디버그 출력

9ea40b5

lamberta requested changes Oct 1, 2019

View reviewed changes

modify metadata for swift

aee2b72

FKgk requested a review from lamberta October 3, 2019 11:54

FKgk added 5 commits October 28, 2019 00:36

modify tanslation

df44872

modify tanslation adding type-safe

77e7f4b

Retranslation

0b3a34e

Retranslate basic

f6f7366

modify double quote

7191bb0

wckim reviewed Oct 28, 2019

View reviewed changes

FKgk added 5 commits October 28, 2019 12:14

move traslation to en docs

f7b3c58

Update en docs url

5ffd04c

modify translation to read easily

5c582a9

modify translation to read easily

e5c25cc

modify translation to read easily

24b9a38

FKgk added 4 commits October 29, 2019 16:21

update url in github and colab

012aa5d

add space

03dba97

add space

01ba431

change Python qoute

f78414c

tfdocsbot added kokoro:force-run lgtm Community-added approval labels Oct 31, 2019

kokoro-team removed the kokoro:force-run label Oct 31, 2019

MarkDaoust added ready to pull Start merge process and removed awaiting-translation-review labels Nov 10, 2019

MarkDaoust approved these changes Nov 10, 2019

View reviewed changes

lamberta added a commit that referenced this pull request Nov 11, 2019

Merge pull request #1062 from FKgk:python_interoperability

47eeb65

PiperOrigin-RevId: 279790594

lamberta merged commit f78414c into tensorflow:master Nov 11, 2019

KO: add site/ko/swift/python_interoperability.ipynb #1062

KO: add site/ko/swift/python_interoperability.ipynb #1062

Uh oh!

Conversation

FKgk commented Oct 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

tfdocsbot commented Oct 1, 2019

tfdocsbot commented Oct 1, 2019

wckim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FKgk Oct 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FKgk Oct 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wckim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FKgk commented Oct 28, 2019

wckim commented Oct 29, 2019

FKgk commented Oct 29, 2019

FKgk commented Oct 31, 2019

wckim commented Oct 31, 2019

cre8tor commented Oct 31, 2019

FKgk commented Nov 10, 2019

MarkDaoust left a comment

Choose a reason for hiding this comment

Labels

9 participants

FKgk commented Oct 1, 2019 •

edited

Loading

FKgk Oct 1, 2019 •

edited

Loading

FKgk Oct 1, 2019 •

edited

Loading